-
-
Notifications
You must be signed in to change notification settings - Fork 101
chore: update deps #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps #436
Conversation
5f55682 to
ec20f05
Compare
ec20f05 to
8834a65
Compare
Uzlopak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not directly use fetch? I would prefer removing that helper fn
|
@Uzlopak wouldn't that require more boilerplate in every test? |
|
@kibertoad Actually not. |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
gurgunday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Uzlopak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job
gotin tests in favor of native fetch@jsumners/line-reporteras in case of failures it's not possible to see output